Skip to content

Correct default firewall name on Security docs #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Correct default firewall name on Security docs #7928

wants to merge 3 commits into from

Conversation

sdknjg8zxq
Copy link
Contributor

@sdknjg8zxq sdknjg8zxq commented May 21, 2017 •
edited
Loading

  • Change firewall name from "default" to "main"

javiereguiluz
javiereguiluz reviewed May 21, 2017
View reviewed changes
security.rst Outdated
@@ -14,9 +14,9 @@ is both flexible and (hopefully) fun to work with.
Since there's a lot to talk about, this article is organized into a few big
sections:

#. Initial ``security.yml`` setup (*authentication*);
#. Initial ``security.yml`` setup (*authentication*).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I also thought this was a mistake ... but apparently is common in English to use a comma after each list element, except the last one. We use that style in the rest of the docs, so we shouldn't change this. Thanks!

@sdknjg8zxq sdknjg8zxq changed the title Apply minor corrections on Security docs Correct default firewall name on Security docs May 21, 2017
@xabbuh xabbuh added this to the 2.7 milestone May 22, 2017
@xabbuh
Copy link
Member

xabbuh commented May 24, 2017

Thank you @eibt.

xabbuh added a commit that referenced this pull request May 24, 2017
@xabbuh
minor #7928 Correct default firewall name on Security docs (eibt)
08d715e 
This PR was squashed before being merged into the 2.7 branch (closes #7928).

Discussion
----------

Correct default firewall name on Security docs

- Change firewall name from "default" to "main"

Commits
-------

8650986 Correct default firewall name on Security docs
@xabbuh xabbuh closed this May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@sdknjg8zxq @xabbuh @javiereguiluz